Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create physical education page #4495

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Create physical education page #4495

merged 15 commits into from
Jan 23, 2025
+112 −0

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Jan 17, 2025

https://trello.com/c/BuiPdY7D

We are creating a PE subject page to help people know what they can teach and help them get the information they need to know if teaching is the right career for them.

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 17, 2025
emmaachesongray
emmaachesongray reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great - left a few comments.

What do you think about adding a teacher stories call out to link this page to the PE inspo page we have about managing behaviour in the classroom?

image

app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
emmaachesongray
emmaachesongray reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really great! Couple of tiny comments.

app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/shared/quotes/_quote-teaching-turning-around-a-lesson.html.erb Outdated Show resolved Hide resolved
app/views/content/shared/quotes/_quote-teaching-turning-around-a-lesson.html.erb Outdated Show resolved Hide resolved
@joegibb joegibb added the policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team label Jan 21, 2025
gemmadallmandfe
gemmadallmandfe reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments for you @joegibb - looks good!

app/views/content/life-as-a-teacher/explore-subjects/_categories.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education.md Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
emmaachesongray
emmaachesongray reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tiny final comments/questions!

app/views/content/life-as-a-teacher/explore-subjects/_categories.html.erb Outdated Show resolved Hide resolved
app/views/content/shared/quotes/_quote-teaching-turning-around-a-lesson.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Show resolved Hide resolved
Sarah-DfE
Sarah-DfE reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial comments for you

app/views/content/life-as-a-teacher/explore-subjects/_categories.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/_categories.html.erb Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education.md Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
app/views/content/life-as-a-teacher/explore-subjects/physical-education/_article.html.erb Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-4495.test.teacherservices.cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
8 Accepted issues

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Sarah-DfE
Sarah-DfE approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joegibb joegibb merged commit 70078de into master Jan 23, 2025
27 checks passed
@joegibb joegibb deleted the create-physical-education-page branch January 23, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe left review comments

@Sarah-DfE Sarah-DfE Sarah-DfE approved these changes

@emmaachesongray emmaachesongray Awaiting requested review from emmaachesongray

Assignees
No one assigned
Labels
content Content changes policy sign off PRs that change the meaning of content in a way that requires sign off by the policy team Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joegibb @gemmadallmandfe @Sarah-DfE @emmaachesongray